Fix issue with convex hull - #2151
Open
Casper Lamboo (casperlamboo) wants to merge 5 commits into
Open
Conversation
Casper Lamboo (casperlamboo)
marked this pull request as ready for review
August 14, 2026 13:53
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit 8f7b84b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some cases the convex hull produces the incorrect (non-convex) results, see attached screenshot.
In this PR a test case with the exact polygon of the example above is added along with a fix for that polygon.
Bug originally found by Thomas Rahm (@ThomasRahm)
Type of change
How Has This Been Tested?
Added a unit test showcasing the issue, with the fix the issue is resolved.
Test Configuration:
MacOS 13.3
Checklist:
CURA-13293